datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

Write a guide on contributing a new expression

Open andygrove opened this issue 1 year ago • 3 comments

What is the problem the feature request solves?

We should write a detailed guide showing new contributors how to add support for a new expression in Comet. This would cover the Scala, Protobuf, and Rust changes, as well as testing approaches. We could create this based on a recent PR that added a new expression.

Describe the potential solution

No response

Additional context

No response

andygrove avatar May 01 '24 19:05 andygrove

Once https://github.com/apache/datafusion-comet/pull/342 is approved/merged and if it's an appropriate example, I'd be happy to write this based off that work.

tshauck avatar May 03 '24 04:05 tshauck

Also related to adding a new expression is adding a new aggregate expression (for example: https://github.com/apache/datafusion-comet/commit/49bf503780dfc93ede968b626214d53fb0953c34)

parthchandra avatar May 03 '24 23:05 parthchandra

And I suppose we also need a separate guide on adding cast expressions since there are specific test considerations

andygrove avatar May 04 '24 16:05 andygrove

This was completed: https://datafusion.apache.org/comet/contributor-guide/adding_a_new_expression.html

andygrove avatar Jul 25 '24 13:07 andygrove