Andy Grove
Andy Grove
> > when the data source is not Parquet: > > when is this true? For Comet sinks, such as: - LocalTableScanExec - CometSparkToColumnarExec - Exchanges - UnionExec - CoalesceExec
Another related timezone issue: Cast from string to timestamp: ``` case DataTypes.TimestampType if timeZoneId.exists(tz => tz != "UTC") => Incompatible(Some(s"Cast will use UTC instead of $timeZoneId")) ```
@coderfender is planning on working on this one
Some notes from debugging this: `CometExecRule` performs the following transformation: ``` INPUT: Exchange hashpartitioning(date_id#5283, product_id#5284, units_sold#5285, store_id#5286, 5), ENSURE_REQUIREMENTS, [plan_id=860] +- HashAggregate(keys=[date_id#5283, product_id#5284, units_sold#5285, store_id#5286], functions=[], output=[date_id#5283, product_id#5284, units_sold#5285, store_id#5286])...
We see the same issue in https://github.com/apache/datafusion-comet/issues/2649
Thanks @akupchinskiy. I plan on reviewing this after the holidays.
I upmerged this PR and re-triggered the workflows. Sorry for the delay @akupchinskiy