Andy Grove

Results 657 comments of Andy Grove

I think we are getting close to being able to release 0.1.0 now that we are using an official DataFusion release again (or will be in a few days when...

@viirya @parthchandra I no longer think that it is critical to fix https://github.com/apache/datafusion-comet/issues/387 before we release, because users can already enable shuffle, so this is just a config change from...

Related issue in DataFusion: https://github.com/apache/datafusion/issues/9603

Thanks @advancedxy. I plan on reviewing this PR today. Could you also update `docs/source/user-guide/expressions.md` to add xxhash64 as a supported expression?

I'd like to see the tests use some randomly generated inputs. As a quick hack, I added the following test to `CometCastSuite` and it shows some differences in results between...

Our `hash` implementation is also not compatible with Spark. I will file an issue for that.

See https://github.com/apache/datafusion-comet/pull/426 for proposed DataGenerator class

> Our `hash` implementation is also not compatible with Spark. I will file an issue for that. I filed https://github.com/apache/datafusion-comet/issues/427

I plan on creating a PR to update our documentation to make it clear that we only support Apache Spark and not other Spark implementations.

The documentation does now state that we only support open-source Apache Spark, so I will close this issue