Alya Abbott
Alya Abbott
I'll retest when the PR passes tests (or let me know if there's some unrelated reason why tests are failing). Thanks!
Ah, got it.
Testing the PR, looks like this hasn't been implemented yet? > let's change the button to "Add streams"
Other notes: 1. Let's remove the ability to drag stream names, as the ordering is not meaningful. (As noted earlier, "the streams don't need to be draggable.") 2. Can we...
For some reason the modal got stuck when I pressed "Add streams" just now, even though I could see the stream I added appear in the list behind the modal:...
> I think "Select" would be better than having it empty. Hm, how about let's try "Select stream"?
Cool, looks good to me! Could you please ping @sahil839 for a review once the tests have been updated?
@ganpa3 Did the rebase resolve the dropdown issue?
@vivekrajput566 please take a look at the [Zulip contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html) to learn how to get started. Also, keep in mind the following guideline: > Before you claim an issue, you...
@saransh12345 prior to claiming an issue, please review the [Zulip contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html). @rodrickcalvin you may find it helpful as well.