Alya Abbott
Alya Abbott
Ah, I see, I misunderstood the discussion above. Sorry about that!
@sahil839 as the next step, could you please review this PR?
Sounds good. @ganpa3 I can test when the conflicts have been resolved.
> The Save changes button has same color in disabled state. (I can see it was grey previously in disabled state in the GIF https://github.com/zulip/zulip/pull/22944#pullrequestreview-1116602685.) This is for all the...
Without re-reading @sahil839 's [comment](https://github.com/zulip/zulip/pull/22944#issuecomment-1437159341) , I noted the same two things when testing. I'm OK with it being merged as-is, and maybe filing both as follow-up issues.
OK, I filed #24567 and https://github.com/zulip/zulip/issues/24568. The latter should be marked as "help wanted" once this PR has been merged.
Cool, thanks! Some comments on this one: 1. Similar to the other one, let's disable the "Save" button when the stream name is empty. 2. To avoid invalid stream names,...
I was also thinking the "Add stream" button looks very tall next to the next to the search field. Maybe we can experiment with making it less tall? ![Screen Shot...
After playing with the UI some more, I was thinking it would be a lot more convenient to be able to add multiple streams at once. Could we replicate the...
Cool! Just looking at the GIF so far, let's change the button to "Add streams", and the modal heading to "Add default streams". Would it be easy to show an...