Alya Abbott
Alya Abbott
@ganpa3 is this ready for code review? @sahil839 would probably be a good person to take a look next.
@timabbott ready for integration review based on prior reviews by @sahil839 and myself. (I have not re-reviewed after the latest set of changes).
> > In the stream creation form, if I type an invalid value which does not matches in typeahead and click on Add the widget is cleared and the button...
Anyone working on this should keep in mind this note on https://github.com/zulip/zulip/pull/21209: > I think we should take another strategy for this; we should just display a Tippy tooltip for...
@abhishek0chauhan please see our [guide for contributors](https://zulip.readthedocs.io/en/latest/overview/contributing.html) to get started. This is a pull request, not an issue.
@yogesh-sirsat will you have a chance to review this one?
Thanks for the review! The role behavior seems like a bug -- it should be possible to just change the role, and save your changes.
> when we remove the changed data the save changes button does not go into a disabled state. Yeah, I think ideally the button should be disabled in that case,...
@ajjayymahato this is a pull request, not an issue. Please go through the [Zulip contributor guide](https://zulip.readthedocs.io/en/latest/overview/contributing.html) to learn how to get started.
> The role behavior seems like a bug -- it should be possible to just change the role, and save your changes. I think this part is critical, so if...