Alya Abbott

Results 1722 comments of Alya Abbott

Fix minor bugs in bot management modal

@KarishmaVanwari There's an in-progress PR for this issue, so it would probably be best to pick a different one.

invite_user: Convert overlay to `dialog_widget`.

Hm, for some reason the "Invite users" modal is not opening for me at all -- the links in the right sidebar and the gear menu change the URL to...

invite_user: Convert overlay to `dialog_widget`.

Thanks! We should make the Cancel / Invite buttons part sticky, like it currently is, so that you can always see it even in short windows.

invite_user: Convert overlay to `dialog_widget`.

@sahil839 Would you be up for reviewing this PR? It might be good to get this merged before @laurynmm works on disabling the invite flow in demo orgs when there...

invite_user: Convert overlay to `dialog_widget`.

Thanks! 1. I think this was discussed on another PR, but the big regression from my perspective is that the buttons at the bottom are not sticky. 2. Let's make...

invite_user: Convert overlay to `dialog_widget`.

Hm, it looks like the changes didn't get pushed?

invite_user: Convert overlay to `dialog_widget`.

Thanks, looks reasonable to me! @sahil839 Is this PR ready for Tim to take a look once it passes CI?

keyboard_ui: Add a new keyboard shortcut '='

Thanks, works for me in manual testing! @amanagr are you up for reviewing this one?

keyboard_ui: Add a new keyboard shortcut '='

@timabbott There's a small unresolved comment from @N-Shar-ma above, so hopefully @SameepAher will push an update before you look. :) Also reviewed by @amanagr and me.

google_analytics: Track realm registration separately from user signup.

@timabbott adding the "integration review" label so that we don't lose track, since @amanagr has updated the PR in response to your feedback.