Alya Abbott

Results 1722 comments of Alya Abbott

I see this when trying to add a group to itself: ![Screenshot 2024-10-18 at 10 09 34](https://github.com/user-attachments/assets/84ddd267-443c-4f09-9b9a-6ec795d80c35) Will taking it out of the typeahead would be covered by the DAG...

I actually go this when trying to add a group for the second time: ![Screenshot 2024-10-18 at 10 15 31](https://github.com/user-attachments/assets/5dea25bd-7533-4e7d-bb87-6896e3c431e5)

#31850 also notes a change to the placeholder text.

Thanks! The icon placement doesn't look right to me in the compose pill. It seems a bit too big, too low, and too close to the name.

Once fixed, please include a light theme screenshot as well.

That's looking better! Please clean up your commit history and post again to request a review. See [here](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html) for guidelines.

Also, please add a screenshot with a very long bot name that gets abbreviated with `...`. We still want to show the icon in that case.

Thanks! @karlstolley are you up for reviewing this one? I haven't tested.

I believe @karlstolley was requesting side-by-side before/after screenshots. You can use a table to make them easy to compare.

> While testing I saw that a user who is not part of the can_access_stream_topics_group can see all the topics in left sidebar. I don't think we want that. Agreed.