Alya Abbott
Alya Abbott
Ah, OK, that's all right, then. @timabbott ready for your review.
@prakhar1144 would you be up for re-testing to confirm that this issue can be closed?
Great, thanks!
I'm closing this issue as resolved, as the remaining point is tracked as https://github.com/zulip/zulip/issues/23327.
@timabbott I'm changing the label to "integration review". Light theme was successfully tested on CZO; dark theme is waiting on #21750 to be resolved, at which point we should re-test...
Yeah, that sounds right to me, though we should check what happens if you have a long message with some code towards the bottom.
Hm, the disabled pointer in the screen capture above doesn't match what I see in other settings (e.g. deactivate organization without permission, etc.).
Ah, got it, I hadn't realized the cursor looks so different on different systems (mine is grey, not red :)).
I played with the PR -- looks good to me! I guess there is a test to fix?
@ganpa3 once this PR is finalized, would you be up for going through the org settings and disabling all the other "Add" buttons when required input fields are empty? There...