Alya Abbott

Results 1722 comments of Alya Abbott

modal: Make the modal content scrollable instead of the whole modal.

The screenshots above look good to me! Just to check, can you also post screenshots for light theme? Thanks!

modal: Make the modal content scrollable instead of the whole modal.

Cool, looks good to me when doing a bit of manual testing (and in the screenshots above)! @timabbott you may want to prioritize reviewing this one, as it blocks getting...

modal: Make the modal content scrollable instead of the whole modal.

I'm seeing a regression with the "Move messages" modal in really short windows. Visually, one can get weird effects: And then if the window is really short, there is no...

stream_settings: Add an option to make a stream default for new users in stream creation and editing UIs.

Thanks for the bump! A few tweaks: 1. When the checkbox option is disabled, the label for it should be greyed out, as we do in organization settings. 2. We...

stream_settings: Add an option to make a stream default for new users in stream creation and editing UIs.

Looks good to me otherwise!

stream_settings: Add an option to make a stream default for new users in stream creation and editing UIs.

(sorry, closing the PR was a misclick)

stream_settings: Add an option to make a stream default for new users in stream creation and editing UIs.

Cool, thanks! The screenshots look good to me, so you can ping @sahil839 for another round of review once conflicts have been resolved. @sahil839 please go ahead and mark this...

flatpickr: Fix the `onKeyDown` listener to handle non-hotkeys.

I confirmed that #23330 is resolved in manual testing.

flatpickr: Fix the `onKeyDown` listener to handle non-hotkeys.

@timabbott tagging for you to take a look, but please feel free to redirect to someone else for an initial review.

flatpickr: Fix the `onKeyDown` listener to handle non-hotkeys.

@N-Shar-ma would you happen to have time to review this one? No worries if not, just let me know!