Adam Scott

Results 211 comments of Adam Scott

I'm all aboard the C++20 train. Maybe for 4.5?

> @adamscott Friendly reminder bump! Oops. I didn't see that the build failed. Gonna fix that tomorrow morning.

Just updated the PR. Should work, now.

Your PR does two things: 1. removes compiledb props. 2. adds example comments. I would remove the example comments for now, just for this PR to concentrate on compiledb.

Does your solution makes the compiledb command for the template code? Like, I know that godot-cpp creates a compile_commands.json, but what my code did was to create compile commands for...

> Can confirm the `compiledb` parameter still exists on this branch, `compile_commands.json` can still be generated using `scons compiledb=yes compile_commands.json`. > > ![SCR-20241029-pzew](https://private-user-images.githubusercontent.com/2308167/381238510-8f14e5fc-4e3c-418f-b8e7-eebdc685ef2b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA3NTA5MDksIm5iZiI6MTczMDc1MDYwOSwicGF0aCI6Ii8yMzA4MTY3LzM4MTIzODUxMC04ZjE0ZTVmYy00ZTNjLTQxOGYtYjhlNy1lZWJkYzY4NWVmMmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMDRUMjAwMzI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2FjZTc1ZmRkNTJjNjBmNmRjMGE2MTYxM2VmODAxZTM1NmQ1NTMyOTkwOTVkMmZiNWVjYjIwOGY0NzZjNDQ1MyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ZMN9sBxMmFzJo3rH26HpcN2C06d0IT01i9nhYbIDj_I) ~~I don't get the same results. `./godot-cpp/compile_commands.json`...

I would keep `Node::_get_configuration_warnings()` and similar methods for backward compatibility sake. Removing the functionality would break so many plugins. I would make it so that if configuration info is given,...

> Any other considerations for this PR? cc. @KoBeWi

I tested `String::replace_char(s)` with emojis and it seems to fail. 🤔 ```diff diff --git a/tests/core/string/test_string.h b/tests/core/string/test_string.h index 697347b409..2183e4ce0f 100644 --- a/tests/core/string/test_string.h +++ b/tests/core/string/test_string.h @@ -433,6 +433,7 @@ TEST_CASE("[String] replace_char") {...