godot icon indicating copy to clipboard operation
godot copied to clipboard

Consolidate remembering window settings into single config

Open bits-by-brandon opened this issue 1 year ago • 3 comments

Fixes https://github.com/godotengine/godot/issues/97051 by consolidating the remember_window_size_and_position editor config into a new Auto option in interface/editor/editor_screen.

Screenshot 2024-09-23 at 11 14 46 AM

Tested locally on MacOS build

bits-by-brandon avatar Sep 22 '24 17:09 bits-by-brandon

I'm not sure what's causing the build fail GHA / 🐧 Linux / Editor w/ Mono (target=editor)

bits-by-brandon avatar Sep 23 '24 01:09 bits-by-brandon

The project manager's Auto option does not work. The window spawns at 0, 0 and moves to screen center, always on screen 1.

KoBeWi avatar Sep 23 '24 13:09 KoBeWi

@KoBeWi

The project manager's Auto option does not work. The window spawns at 0, 0 and moves to screen center, always on screen 1.

Refactored to only apply settings in the editor and not to project manager, which was never implemented. Also creates a separate enum to capture valid values of the editor config, which mirrors screens but also has the new possible "Auto" value

bits-by-brandon avatar Sep 23 '24 15:09 bits-by-brandon

Any other considerations for this PR?

bits-by-brandon avatar Sep 26 '24 12:09 bits-by-brandon

Any other considerations for this PR?

cc. @KoBeWi

adamscott avatar Sep 27 '24 16:09 adamscott

@AThousandShips @KoBeWi Made changes!

bits-by-brandon avatar Sep 29 '24 23:09 bits-by-brandon

I pushed an update to squash the commits together, as per our preferred PR workflow.

akien-mga avatar Oct 01 '24 14:10 akien-mga

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Oct 01 '24 15:10 akien-mga