ThrawnCA

Results 345 comments of ThrawnCA

Looks like 2.9 isn't compatible with the newer SQLAlchemy. We should probably make version-specific requirements files.

Since we have added the `--sync` flag to enable synchronous XLoader processing, we should be able to adapt our tests. We can split them to have one test that just...

Encountering difficulties around changes made to the `index_package` function and how it interacts with custom package schemas.

It turns out that some corner-cutting for the sake of efficiency (skipping API layer to go straight to the model) in https://github.com/ckan/ckan/issues/3245 interacts badly with recent changes made for https://github.com/ckan/ckan/issues/8395...

> We need to introduce support for a new config option similar to [ckan.datapusher.callback_url_base](https://docs.ckan.org/en/latest/maintaining/configuration.html#ckan-datapusher-callback-url-base) which will allow xloader to call e.g. `http://ckan:5000/dataset/{id}/resource/{id}/download` instead of `https://myckan.site.org/dataset/{id}/resource/{id}/download` I'm a little confused about...

> There can be network restrictions or reverse proxies that in prevent accessing "outside" resources from the web server. Wouldn't that make the XLoader essentially unusable? I suppose it could...

Could this be handled instead by making `authz.is_authorized` recognise the context `user` object as an alternative to `auth_user_object`?

> It probably has wildly different direction what you have done though. Feel free to ask about any of our changes if the commit history doesn't explain enough.

I don't see any PR template at all? Just tried opening a new PR and there was no template.

> Is there any specific reason it wasn't merged at the time with the positive review it had? I can only speak for myself and say I'm pretty sure I...