ThrawnCA

Results 345 comments of ThrawnCA

> @ThrawnCA broken test is unrelated? It looks unrelated, yes. This PR only changes the Solr container.

> ThrawnCA you should have write access to this repo (or have a pending invite to join) I have write access, yes.

@JVickery-TBS You need to update the Solr test container name from the obsolete "ckan-solr-dev" to just "ckan-solr".

This appears to be essentially the same as https://sourceforge.net/p/findbugs/bugs/786/ (which was raised in 2009). Are you able to include the InputStreamReader in the `try` resources? Eg: try (FileInputStream fis =...

@iloveeclipse Looks like you closed the original FindBugs issue. Do you know whether ignoring wrappers like BufferedReader and InputStreamReader would lead to significant false negatives? It appears to be pretty...

Please [avoid force-pushing](https://www.atlassian.com/git/tutorials/merging-vs-rebasing#the-golden-rule-of-rebasing); it wrecks the history.

> I'm personally not so positive for this feature. Immutability is something able to judge automatically, no need to ask human to provide a list. Human makes mistake, so I...

> I've spent some cycles trying to get a debug environment with Jetty working and I'm not having much luck. I'm blocked just getting jetty and intellij idea to work,...

> hey @ThrawnCA , if we update DataTables in future, this will get replaced and lost. Where is the right place to submit this, then?

> @ThrawnCA Could we host the json file from the our datatables extension code instead of mixing it with the vendor files, and reference it as a plug-in https://datatables.net/plug-ins/i18n/ ?...