ThrawnCA

Results 345 comments of ThrawnCA

javap output: public class au.gov.qld.ssq.service.bpoint.BPointOrphanTransactionResolver SourceFile: "BPointOrphanTransactionResolver.java" InnerClasses: public static #196= #90 of #237; //Entry=class java/util/Map$Entry of class java/util/Map minor version: 0 major version: 51 flags: ACC_PUBLIC, ACC_SUPER Constant pool:...

OK, either I was reading it wrong before or it's detecting the line numbers better now. Yes, it's reporting on the `currentCriteria = new SearchCriteriaBuilder()` line. Still seems like a...

`SearchCriteriaBuilder` is stateful. That *might* be possible, but is too error-prone if we don't override all relevant aspects of its state. Not entirely comfortable doing that.

Basically, it's generally not a good idea for the abstract parent to know about the subclass. If the singleton can be expected to always be of the subclass type, why...

@ddesna That appears to be unrelated to the original issue here, and it also appears to be a straightforward case where there is indeed a circular dependency. If `Utils` is...

I'm unclear on why you think this is a false positive. Can you provide a sample of code that triggers the detector but should not?

The point of the rule is to catch situations like: StringBuilder s = new StringBuilder('a'); Presumably the developer intended to create a new StringBuilder with the default capacity, containing a...

[`StringUtils.contains`](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#contains-java.lang.CharSequence-int-) is probably the best of both worlds here.

That looks like the correct coordinates, yes. Sorry, I don't think that there's an official changelog.

Have you read the description of `HCP_HTTP_REQUEST_RESOURCES_NOT_FREED_LOCAL` at http://fb-contrib.sourceforge.net/bugdescriptions.html ? Garbage collection will *not* free up all the resources held by a HttpRequest. You need to explicitly `reset` your HttpPost.