ckanext-xloader icon indicating copy to clipboard operation
ckanext-xloader copied to clipboard

SQLAlchemy v2 support

Open smotornyuk opened this issue 1 year ago • 3 comments

Compatibility with the new SQLAlchemy version tested against this PR.

smotornyuk avatar Sep 10 '24 17:09 smotornyuk

Looks like setup tools for 2.9 has started to fail unrelated to your changes.

  /usr/lib/python3.9/site-packages/setuptools/_distutils/dist.py:261: UserWarning: Unknown distribution option: 'tests_require'

duttonw avatar Sep 10 '24 20:09 duttonw

Looks like setup tools for 2.9 has started to fail unrelated to your changes.

We can fix that, but I'll note that with the release of CKAN 2.11, 2.9 is no longer officially supported: https://ckan.org/blog/the-new-ckan-211-release-is-now-available

ThrawnCA avatar Sep 10 '24 23:09 ThrawnCA

Looks like 2.9 isn't compatible with the newer SQLAlchemy. We should probably make version-specific requirements files.

ThrawnCA avatar Sep 10 '24 23:09 ThrawnCA

I've cut a release today for 1.2.0 which is compatible for 2.9 ~ 2.11.

I'm ok with dropping 2.9 support via this PR, I've updated the doc's and cicd pipeline accordingly.

I'd like to pull in the last pieces of work from the qld-gov-au fork prior to this being included for one last 1.x.x release.

As this is major breaking change, it should bump to 2.0.0 on this being merged into master/released.

duttonw avatar Oct 15 '24 04:10 duttonw