ThrawnCA comments

Results 345 comments of


                                            ThrawnCA

Detect improper args for SLF4J Logger::error

> When really we want to call `public void error(String msg, Throwable t);` But you've provided three arguments.

Detect improper args for SLF4J Logger::error

"the log message that's generated isn't what's expected." Can you provide the expected vs actual log messages? I'm still confused about exactly what the problem is. What is incorrect about...

SEO proposes unsafe optimizations

Truthfully, I think that your best tool here is unit test coverage. If you had unit tests covering the three branches - first half fails, second half fails, both halves...

Detector suggestion: Expecting Error in unit tests

It's more "if you expect `AssertionError` or any superclass of it, report that." IMO you don't need to look for an actual assertion in the method body. AssertionError is pretty...

PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS not applied to static initializer

Yeah, PRMC is meant for methods, so suppressing it on a field - I'm not surprised that that doesn't work. If it's more acceptable, you could move the initialisation into...

SUI_CONTAINS_BEFORE_REMOVE false-positive

This is quite odd logic. If `something` is unrelated to the presence of the item in the collection, perhaps you could put the null check outside of the `contains` check?...

[Java 11] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE false positive

Does this reflect real code? I can't fathom what real-world situation would look like this.

false-positive for ITC_INHERITANCE_TYPE_CHECKING in overridden method

Can you give a code example?

Suggested extension: Check printf pattern in org.apache.logging.log4j.Logger.printf(Level, message, ...)

I've constructed a minimal test case for this, and I get CNT_ROUGH_CONSTANT_VALUE and SPP_USE_MATH_CONSTANT for both usages, with no difference between `System.out` vs `Logger`. (@mebigfatguy Is SPP_USE_MATH_CONSTANT redundant?) package spotbugs.test;...

Suggested extension: Check printf pattern in org.apache.logging.log4j.Logger.printf(Level, message, ...)

Could be, but I'm not getting any bug reports for that, with either usage.