Matt Corallo comments

Results 959 comments of


                                            Matt Corallo

Make `tx_abort` a variant of `InteractiveTxMessageSend` and refactor

We're gonna walk back our v2 enablement for 0.1, so this needs to happen for 0.2.

Sort out `DiscardFunding` event with tests for V2 channels

We're gonna walk back our v2 enablement for 0.1, so this needs to happen for 0.2.

Store `Feature` flags in line rather than on the heap by default (without increasing their size)

Went ahead and squashed to see if CI will run again.

Store `Feature` flags in line rather than on the heap by default (without increasing their size)

Also made clippy happy: ```diff $ git diff-tree -U2 a07c020d4 4a841aac3diff --git a/lightning-types/src/features.rs b/lightning-types/src/features.rs index 804083d65..d97347b47 100644 --- a/lightning-types/src/features.rs +++ b/lightning-types/src/features.rs @@ -816,5 +816,5 @@ impl DerefMut for FeatureFlags {...

Store `Feature` flags in line rather than on the heap by default (without increasing their size)

Squashed without further changes.

`rustfmt` non-test `ln` module's not-currently-being-edited files

All trivial changes and there's two reviews so not worth waiting.

Expose `advance_path_by_one`

Then I'll leave the milestone on it, though its somewhat optimistic it'll make it.

Support new experiemntal ranges for offer tlvs

We now support ignoring experimental offer TLVs, but we still need to support actually setting/reading them.

Request Flood Fills Cache Disk and causes further requests to fail

Yes, I control the upstream so can ensure large files are marked no-cache which solves it for me, but whether this is architectural or not it really quite needs fixing...

Rustfmt Maximalism

After rebasing my own rustfmt stuff I realized that the main rebase logic won't actually work in some cases around indentation changes. Because git sometimes mis-identifies hunks as non-conflict it'll...