Matt Corallo
Matt Corallo
You should ensure that you're fully complying with the persistence APIs. Specifically that if you indicate something was durably stored to disk that there's no way for it to not...
Closing as the reporters were unable to provide more details. Happy to reopen it if its still an issue for y'all or we can debug it further.
We should do this, but its a bigger lift. #3384 should get fixed in 0.2 and then this can wait until 0.3/0.4.
Jeff notes in the above references in 808 that we should try to enforce this via an API refactor if possible, eg wrapping ChannelManager in a ChannelManagerSyncing object during deserialization...
CC #4048
A duplicate event isn't an error, though, its an expected condition. An error there might imply that the dev should return an error in the event handler, which will result...
Oh, right, I forgot about that PR. Ugh, yea, maybe indeed.
LMK if I should squash.
Squashed without further changes.
Rewrote the last commit message but didn't change the diff at all.