Matt Corallo
Matt Corallo
Is the code for this somewhere I can test? :p
There's another reason that it exists that is missed here - JSON-RPC is basically a Bitcoin Core-only thing, and is pretty hard to work with. There isn't standard tooling for...
I've now seen this twice, the second time the peer was running "master... something between 0.15 and 0.15.1 115b0418747ba941875bd9f2be1bb18754f6f636"
Yes, the type bytes written on the wire is pulled directly from https://github.com/lightningdevkit/rust-lightning/blob/main/lightning/src/ln/wire.rs#L308
I'm not sure how any old code should have caused this, either? The message here is odd, which the spec has always mandated must be ignored if they aren't understood,...
Hmm, so for the peer in question here, the only non-ping/pong log lines for c-otto's node I have within two minutes leading up to the force close are as follows,...
It means its outright invalid. I haven't dug into why, however, its possible its just things with the hostname field that we decide are invalid, given that's the big change...
Agreed the BOLTs should be tightened, but the peer is clearly *known*, even if they're offline. The other point is the definition of `PERM` is much more clear, and `unknown_next_peer`...
FWIW, the use of `temporary_channel_failure` as a bit of a catch-all is also a deliberate decision to provide a more general protection/strategic ambiguity as to balance probing, so there's very...
Hmm, good point, both would be valid here, I assume, in either case you'd include a `channel_udpate` with the disabled bit set, which ultimately the sender should treat the same...