Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

`lightning-liquidity::lsps2::event::LSPS2ServiceEvent::OpenChannel` is incredibly unclear

Okay but the events also don't currently rely on/expose a `user_channel_id`, and its very unclear to me why that would be a requirement.

Add liquidity checks and improve payment error handling

Looks like all CI is failing here :(

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

There's still a few `Box::pin`s in `lightning-background-processor` that we really should be able to get rid of, but its not entirely trivial so I didn't do it here.

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

> Given how much this cleans up the new async traits, I do wonder if we want to ship this for 0.2 afterall? Meh, I don't think they clean them...

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

Rebased to pick up #4180, this should now pass CI (modulo fuzzing, which still confuses me).

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

The CI failure is https://github.com/bitcoindevkit/rust-electrum-client/issues/181 which is unrelated to this PR and its just that we're now testing it.

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

Rebased for the restoration of the `lazy` flag.

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

Fixed a bunk rebase.

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

Oops, fixed a no-std error in the new BP stuff: ```diff $ git diff-tree -U1 05717d0860 20697053c diff --git a/lightning-background-processor/src/lib.rs b/lightning-background-processor/src/lib.rs index 874c82f19d..bc0d42ac19 100644 --- a/lightning-background-processor/src/lib.rs +++ b/lightning-background-processor/src/lib.rs @@ -43,2...

Reduce `Box`ing using `impl Trait` in trait methods post-MSRV-bump

Oops, no big deal, done.