Matt Corallo

Results 959 comments of Matt Corallo

I dont think we ever do backwards-facing changes for style guidelines, no reason to start now?

I mean the change itself seems fine, but the project is already inundated with a flood of cleanup fixes, so I'm not sure *more* is worth it. Feel free to...

Lol, probably easier to delete this repo. Scanning the network in PHP is not, exactly, a good idea (also note the, much newer, much nicer, rust-based seed scanner in my...

A straight constant hash value would likely be ideal. The goal here ultimately is full determinism in the sense that if you run the same code in the same order...

> I can add a flag to do this, but it still won't make the process fully deterministic if there is a non-ahash hashmap used anywhere. Sure, for my use-case...

Oops, I'm sorry this somehow fell off my stack. > The only thing I don't like about fuzzing is the connection is not clear. Nothing is being specified on this...

> I have sortof a prototype of this. (Though annoyingly it does not work on ARM) Cool! Thanks. > The basic idea is that we could have a feature/flag to...

ACK, must've missed the TBC reference...

Would be interesting to see where the hashing is - are you verifying the merkle tree or just getting transaction txids to store into a map?

> Interestingly hashing takes a lot of time in case of index queries too: I don't see any hashing here? Only from-hex conversion.