Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

Some `Listen` implementations assert that each block is exactly after the previous

Sure, but the `Filter` may update during a block-connected call, and then the call has to be made again with what is *now* the relevant transaction set. This has always...

Some `Listen` implementations assert that each block is exactly after the previous

I don't see why we need to block #3876 on making an unrelated further change to `Filter`/`Listen`? But I also don't see how we can possibly change this requirement. We...

Some `Listen` implementations assert that each block is exactly after the previous

There's a tradeoff between `Filter` size and this requirement - if we want to register everything that we might want to hear about, we'd have to register most of the...

Some `Listen` implementations assert that each block is exactly after the previous

Mmm, that's a good point, yes. Not 100% sure "lightning commitment txn will only ever have outputs that are 1 CSV" is a great assumption to make at the API...

Some `Listen` implementations assert that each block is exactly after the previous

This is gonna have to be an 0.2.1 thing. Its a bug but not a regression so we'll backport it anyway.

Provide next inbound htlc max value field in ChannelDetails

There's no urgent pressure for this. We do want it for, eg, blinded path calculation, but we're in the midst of rewriting much of the balance calculation logic, so this...

Add an implementation of mutual message exchange

Needs fuzzing before this lands.

Add an implementation of mutual message exchange

Rebased.

Add an implementation of mutual message exchange

Closing due to lack of downstream project interest. I assume I'll pick this back up eventually.

Gossip never seems to get a full take from Eclair/CLN

Yea, I think its quite likely just that the peer in question doesn't have the whole gossip map. I guessed it was ordering because we get a lot of errors...