Matt Corallo
Matt Corallo
Squashed without further changes.
cc @alecchendev cause I can't assign you.
> Would it be a good take-a-Friday issue to fix the legacy tests that use both sync + async so we don't need to gate the panics anymore? Yea, I...
Squashed with a minor comment fix: ```diff $ git diff-tree -U1 ddccbdabd d009b3918 diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index c86eed77b..54b607d88 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -2573,4 +2573,4 @@ where ///...
Oof, ugh, right. Squashed-pushed a fix: ```diff $ git diff-tree -U1 d009b3918 cb6219df6 diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs index 54b607d88..34751bfc9 100644 --- a/lightning/src/ln/channelmanager.rs +++ b/lightning/src/ln/channelmanager.rs @@ -2575,3 +2575,3 @@ where ///...
> Wondering whether the problem where chan mgr will be left with a single pending update which is not the latest can also occur when purely async is used, but...
Re-dropped the constant after discussion.
Okay, I believe all feedback has been addressed.
Squashed without further changes.
cc @jkczyz maybe, and obviously cc @optout21.