Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

The ability to build a `ReplyPath` to send messages outside of `ChannelManager`

Ah, good point, indeed. I suppose mostly we're lacking some utility to expose this to users in an obvious way. It'd be nice to be able to call one method...

The ability to build a `ReplyPath` to send messages outside of `ChannelManager`

Ah, so now I don't need this because `release_pending_messages` can now just return instructions that ask the `OnionMessenger` to build the blinded path. Or maybe it always was that way...

Log which hop in a path was the most limiting in capacity

Mmm, thanks, rebased!

Drop deprecated methods in `invoice_utils`

Landed via #3763

Move BOLT 12 into its own crate

Played with this, I don't really actually think its worth it as we'd have to first split out all our TLV and serialization logic into some kind of `lightning-ser` crate...

Move BOLT 12 into its own crate

> And I have also encountered a few user requests that would like to use LDK's BOLT12 de/ser logic independent from the node-y types like ChannelManager. I'm not sure what's...

Make `BumpTransactionEventHandler` async-optional

Grr, right. I suppose we could fix that with `OutputSweeper` having a fixed payout address (or a list) that is pre-configured if users want to avoid that inversion. Still seems...

Run rustfmt on `payment_tests` and `functional_tests` and split up the latter

Rebased and addressed feedback.

Run rustfmt on `payment_tests` and `functional_tests` and split up the latter

Rebased. > FYI, looks like fixup commits weren't added prior to the rebase so it's hard to see what changed. I'm also generally fine with squashing in changes if the...

Run rustfmt on `payment_tests` and `functional_tests` and split up the latter

Rebased and addressed new feedback. Didn't squash yet tho.