Matt Corallo

Results 964 comments of Matt Corallo

Because using `manually_handle_bolt12_invoices` requires a bunch of work, but PoP is something we should encourage all our users to maintain. If we want to require `manually_handle_bolt12_invoices` for PoP IMO we...

Yea, we could have a separate event for it, but its definitely nicer for the user if we provide it all in one go, and I'm not sure its *that*...

This is still pretty important, but everyone has gotten slammed with three other projects, so sadly slipped. We should re-circle in time for 0.2.

Not a huge deal, this isn't *that* critical, given the long burn that BOLT 12 adoption will be/is. Indeed, we're targeting 0.1 (beta) by next week.

From a Bitcoin Core perspective, sure. From the users' perspective I have a bundle of transactions and I want to get them relayed. They may be a package, they may...

> In the implementation for the Keysinterface for KeysManager, the functions returning the destination and shutdown script return a clone of the script. Does a fresh script mean using the...

Oops I'm so sorry I managed to let this fall off my radar. To create a new public key, look at how we derive keys from the master now, and...

Right, we should drop the `destination_script` logic, take the `shutdown_pubkey` and keep it as an `ExtendedPubKey`, deriving new children and then building both a destination and shutdown pubkey with it...

I think we should include the `channel_keys_id` in `SpendableOutputDescriptor::StaticOutput` and use the first 8 bytes (I think HD counters are 8 bytes?) of the channel_keys_id as the key derivation index.

When we do this we should also make the payment_key in the channel less reliant on as much entropy, so that it can theoretically be derived from the seed if...