Matt Corallo

Results 964 comments of Matt Corallo

Squashed without changes then had to rebase to address a conflict: ``` $ git range-diff 8c086c772f2f4def5aecc549b2d39f2ab427081d..ce3b143c314ffb640dbdb569dd6c8882e008a0f3 b0bd4371d989722aa38ddfc2f35db8922e3304bb..cbdb8cb0cb5f1e8b9e676ad2d130b8bbc2b9e640 1: 3fdc51c8b = 1: a39e274e3 Skip the implicit trailing `.` in `HumanReadableName`'s domain...

Also, after we bump our MSRV we can drop all the `Box`es we added in serialization.

You assume a lot about how actively most nodes are maintained...

Slipping. Important but not so important we need to hold.

I played with this a bit, sadly Rust doesn't allow you to convert an arbitrary (`?Sized`) trait impl to `dyn Trait` (as it could lead to building a vtable that...

The type passed to `LoggerScope::new` needs to change to take a `&'a dyn Logger` rather than taking a concrete `Logger`.

I don't think its going to be material in either direct. Storing a `dyn Logger` in TLS shouldn't be more than like an extra 2 or 3 pointers (just 1...

> I had tried that, but it didn't work. Same sized error. Pushed the commit. Maybe I am doing something wrong. Right, looks like claude just forgot to update the...