Matt Corallo
Matt Corallo
CI gets run rebased against upstream so you probably have a silent merge conflict. A rebase should turn it up and then we can land.
Feel free to squash, lets get this over the line!
Sorry for the delay, release process is always fun. I think this LGTM.
We can avoid having to fix this issue if we do #3100 and uncouple the LDK no-std feature from rust-bitcoin no-std.
Fixed the issue dusty pointed out: ```diff $ git diff-tree -U5 90772ff d8cfa95 diff --git a/02-peer-protocol.md b/02-peer-protocol.md index e9ba8bc..3e7ecb2 100644 --- a/02-peer-protocol.md +++ b/02-peer-protocol.md @@ -2480,16 +2480,12 @@ A node:...
Should be ready for review now that the dependent PR landed @arik-so @tnull
Added a commit to set the feature bit added in #3346.
Rebased and addressed CI issues.
Squashed the fixups without further changes.
Addressed feedback and rebased.