rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Log which hop in a path was the most limiting in capacity

Open TheBlueMatt opened this issue 9 months ago • 2 comments

Its generally rather difficult to debug the pathfinding logic from a log, and sadly because we cannot feasibly log each step in a pathfinding search there's relatively few options we have for improving this.

However, one specific question we occasionally get is "why did the pathfinder decide to use MPP"? While we similarly cannot practically log every possible path the pathfinder could have taken to explain why a specific path which required MPP was taken, we can at least explain which hop in the path was the most limited, which we do here.

Based on #3707

TheBlueMatt avatar Apr 10 '25 20:04 TheBlueMatt

I've assigned @valentinewallace as a reviewer! I'll wait for their review and will help manage the review process. Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot avatar Apr 10 '25 20:04 ldk-reviews-bot

🔔 1st Reminder

Hey @valentinewallace! This PR has been waiting for your review. Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot avatar Apr 14 '25 00:04 ldk-reviews-bot

Ready for rebase?

Top commit LGTM.

dunxen avatar May 05 '25 12:05 dunxen

Mmm, thanks, rebased!

TheBlueMatt avatar May 05 '25 13:05 TheBlueMatt