Matt Corallo

Results 964 comments of Matt Corallo

Please squash, yea.

It does, though it should usually be fine - writes shouldn't immediately fail unless we're like out of disk space, at which point we should really panic and crash not...

We now have logic to detect when a `ChannelMonitor` is prunable, so we literally just need to call it from the BP.

This seems pretty broad and somewhat opaque. Moreover, things like “splitting the channel and HTLC state machines” I’m not sure is really practical, so it seems strange to put it...

Right, pulling accounting logic out into separate bits to add such abstractions within channel makes sense, especially as an effort to validate it more thoroughly, I don't think I was...

Removing good first issue, dunno exactly what this would entail but certainly it'd be a lot for a new contributor.

> Within the noise threshold, but not nothing. FWIW I'm *incredibly* skeptical that changing a few boxes would result in a change that is more than 100 nanoseconds across the...

Looking at the contents, ISTM if we just defined a pre-allocated string+vec type, we could reduce our allocations to zero in common cases - if we make `OfferContents::description`, `OfferContents::issuer`, and...

We should probably first finish our upgrade to 0.31 by bumping our bech32 dependency.