Matt Corallo
Matt Corallo
> To me NetworkGraph is our data model for the graph, so storing internal message queues in there seems unrelated? ...but storing message queues seems like an entirely different affair...
#3432 didn't really fix this, just patched around it for ldk-node for now. We should still remove the circular reference.
No strong reason we should hold 0.2 on this.
> This requirement forces the channel opener to contribute to the funding transaction and makes it impossible to open channels by only purchasing inbound liquidity from a remote node. Not...
I'm very, very, very much not a fan of touching the channel state machine just to avoid a round-trip when opening a non-JIT channel. Further, for JIT channels we need...
> The only thing it's changing in the channel state machine is that instead of gating operations based on whether the current node is the channel opener, you simply gate...
After discussion at the summit we concluded that we can avoid this if we move to zero-fee commitment txn, which we agreed loosely to do.
Squashed and rebased, fixing the commit message.
> This isn't used for the introduction node, we're only using this in encrypted_recipient_data.next_node_id. Ah, okay, that's what I thought, that makes more sense. Was just confused by the wording!
I think I agree - I don't think we need to expose this publicly, but I think it may be a useful internal utility to build #3428. Doing it as...