Matt Corallo comments

Results 964 comments of


                                            Matt Corallo

Document persistence failure behavior for all events

Ugh, we should really have gotten to this...

Introduce Dummy Hop support for Blinded Payment Path

> The receiver cannot fail an HTLC backward when dummy hops are present. This shouldn't be an issue? We should be failing all blinded path receives with `invalid_onion_blinding` and we...

`rustfmt`: Run on `lightning-invoice`

There's a lot going on in this crate right now for the bech32 upgrade, sadly, so I'm afraid this might want to wait :/

`rustfmt`: Run on `lightning-invoice`

Blocked on #3270

ensure peer_connected is called before peer_disconnected

Yea, I was figuring you'd just create a trivial `CustomMessageHandler` that asserts that connected/disconnecteds all come in order and then errors on connection.

ensure peer_connected is called before peer_disconnected

Supersceded by #3580.

Persist `ChannelMonitor` after first setting `balances_empty_height` in `archive_fully_resolved_channel_monitors`

Slipping. We really need to do this, but we don't need to hold the release on it.

Rename `Offer::signing_pubkey` to `Offer::issuer_id`

Needs rebase.

Rename `Offer::signing_pubkey` to `Offer::issuer_id`

Feel free to squash.

Rename `Offer::signing_pubkey` to `Offer::issuer_id`

Needs rebase :/