Matt Corallo

Results 964 comments of Matt Corallo

One downside here is it relies on the recipient using a static offer signing pubkey, which by default they almost certainly should not do. A radically different approach would be...

> It is very important in my opinion that "adding a contact" is as simple as entering a BIP 353 address or scanning a QR code and clicking a "store...

> I don't understand, that's not at all what I'm specifying here? When you'd pay one of your trusted contact, you would use the offer signing key of the current...

I think the only real TODO here is to include channel capacities in RGS data.

From the PoV of gossip splices are just "new channels between the same nodes". I don't see a reason why we'd treat it differently in RGS (it would be nice...

I believe that fails not just for invoices but also invoice_requests and maybe others.

> With the latest fixes, the following checks should pass except for the unknown / experimental cases where bytes is directly modified in those tests. Is it possible to go...

> But aren't we holding cs_main throughout the process? Doesn't mean we can't build a new block. There's several ways we might build a new block here - (a) we...

I think there's about four reasons to want to switch around the mining interface to be push-based (rather than the current request-based): 1) reduces (tail) latency when requesting a block....