Starlight220
Starlight220
Add tests to confirm no bugs happen if the selected/active option is removed and/or a nonexistent option is selected. I suppose that the correct behavior would be returning the default.
I'm worried about this inflating headers and compile times due to everything becoming a template.
We can make the currently-explicit conversions to `CommandPtr` implicit... Thoughts?
I made the changes locally, and it's causing some issues. Maybe we should be consistent on everything being `CommandPtr` and that's it? To avoid the shenanigans of implicit conversions. >...
We can include all member names in the composition name, though it will cause extremely long names that might be trouble for network and readability - albeit `withName`ing commands could...
> might cause weird behavior if the commands in the composition change after being sent to a dashboard I think this type of use should be discouraged anyway. And `getName`...
Should also be done for everything else (HAL, etc)
It's also supported by the AnalogPotentiometer class when connected directly to the RIO
I suspect this is an issue with resetting preferences not being properly reset between test cases, and not in the example itself.
I tried working on something similar this morning, tests failed with weird mock calls. I'll open a PR too to compare changes.