Starlight220
Starlight220
May have been fixed by #780 in 2023.4.3; can someone reproduce?
I think that middle ground solution should be introduced at a larger scope and not here. I've reduced the scope of this PR to only remove the `isFinished` check. There...
I wasn't able to reproduce the hang in Java/C++. In Java, we can check and throw in `SimDevice.create`, but in C++ `SimDevice` doesn't have access to `frc/Errors.h`.
I've tried reproducing this locally in sim (with the FMS checkbox enabled). The NT topic changes correctly, and the start/stop recording buttons in the shuffleboard UI do change correctly. Recording...
There were multiple changes between 2022 and 2023 regarding how macos artifacts are handled; I expect that's what fixed it. Can this be closed?
That example wouldn't work because of reassignment and capture semantics.
I do think there's value in pre-built base classes or templates for integrating control loops into commands, ie a command class that has prebuilt factories for commands like going to...
If the control commands are staying, I'm not sure it's needed. If this PR is focused on deprecating control subsystems, TimedCommand is out of scope.
The control subsystems need to go. However, the control commands are relatively useful, and I'm not sure we should remove them. Thoughts?
Isn't the command part solved by #4735 and the Sendable part resolved by `publishConst`?