Brennan Ravenscroft
Brennan Ravenscroft
Superseded by #1496
This looks like a more minimal version of the `IFormattableAttribute` API supplied by Apothic Attributes, which is a good thing; though I would want to nudge something in a direction...
> allow some attribute modifiers to be hidden from the description We could do that, though it depends what level of control we want to express over the tooltips -...
Superseded by #1551
I agree that patching individual menus is unlikely to be a good long-term solution. Honestly, having just the menu buys you effectively all the context received with the invasive patches,...
It seems like removing `AddReloadListenerEvent#getRegistryAccess()` is the most appropriate course of action. Granted, mods that are deserializing objects should prefer _neither_ of the solutions you have outlined, instead opting to...
What functionality would you need that requires to react to parsing of datapack registry entries at registration that could not be accomplished via reload listener?
I think this is fine, regardless of the minimum requirement actually set by NG, users will need J21 around to actually _do_ anything, and we recommend that J21 be installed...
How does this implementation handle collisions between traits, and between traits and the base class? Is any collision an immediate parse error?
@SeremTitus can you describe your collision handling approach for this implementation? I would like to drill down the details on what it currently handles and how it handles it. I'll...