Brennan Ravenscroft comments

Results 242 comments of


                                            Brennan Ravenscroft

Add level and pos context to `PlayerEvent.HarvestCheck`

If this can be made as a total replacement for HarvestCheck imo we may as well go that route. Additionally, it should be made a standalone class instead of an...

Add level and pos context to `PlayerEvent.HarvestCheck`

Moving away from the player requirement is a good change for automation, as the current flow requires micromanaging a fake player and setting the tool in their hand, when typically...

Add level and pos context to `PlayerEvent.HarvestCheck`

> You will always need a fake player I think The LivingEntity param is nullable, which makes it optional

[1.20.5] Record a BlockSnapshot for client break predictions and cleanup break pipeline

Always the possibility, but I think this one is safe enough

Change Main Menu layout to have full-width Realms and Mods buttons (fixes #249)

Closing in favor of the approach in #997

[1.20.5] Add data-driven brewing recipe system

Given the recent changes to `PotionBrewing` in 1.20.5-pre1, we should dismiss this change and wait for vanilla to provide this functionality natively.

[1.20.5] Add data-driven brewing recipe system

Yeah, this isn't very feasible for us to do atm. Closing.

[1.20.1] Pull `ProjectileHitEvent` changes from MCF/1.20.x

Sounds like we may need to add an `IGNORE` impact result which allows moving/redirecting the arrow without committing the impact.

Split living entity tick (and level tick) into a separate start and end tick event

#542 was updated to include (and split) `LivingTickEvent`

Unable to put enchantments past vanilla max level on items through an anvil.

This issue tends to be caused by other mods that fiddle with the anvil. I can fix it if the offending mod can be sourced, but I will not lint...