Brennan Ravenscroft comments

Results 242 comments of


                                            Brennan Ravenscroft

[Suggestion] Ability to reroll single effect or attribute of an item

https://github.com/Shadows-of-Fire/Apotheosis/commit/7588c8868ad30f770225a04a1def87005b9ab0e3

create attribute documentation

Fair amount of work probably needed here. The current state is unfortunately inbetween "too technical" and "too simple" in that it is not technical enough for advanced users to gain...

Eye of Ender items behave differently than vanilla.

There's no way to keep the patch and maintain the behavior that triggers the particular advancement - the fact that it triggers at all is a bug (as indicated by...

Add c:indestructible tag

I'll be honest a tag like this that does not have any gameplay altering effects does not seem particularly useful. What good is a marker that dictates an item should...

[1.20.4] Select Music Event

Closing due to lack of development; if you ever get around to updating it, you can reopen this or a new PR for the same change.

Make mod’s own use of OnlyIn annotation throw warning or crash in dev

We already suggest proper isolation of client code. See https://github.com/neoforged/MergeTool/blob/main/src/forgeAPI/java/net/neoforged/api/distmarker/Dist.java `@OnlyIn` does have an effect on mod code, but it should not be used by mods whatsoever.

Allow running client commands from chat components

@SquidDev #1231 is stalled for the time being, so if you intend to update this PR, you shouldn't await completion of that change.