Brennan Ravenscroft
Brennan Ravenscroft
I don't think letting a datapack registry be a `DefaultedMappedRegistry` is a good idea, since by virtue of being a data registry, data objects may be removed (including the default...
Eh, well, people can use it at their own risk. It isn't really any different than just calling `.holderOrThrow` on a datapack registry, which people are almost certainly doing.
> I don't like the attempt to remove the registry type generic and then try to materialize it based on T. That is not a goal, nor does it try...
Removed `asHolder` and rebased against `port/1.21`
This pr is updated to 1.21
The idea is good; I would like to see some streamlining in the data provider registration process (especially with the requirement that registry set builders be registered first and then...
I'm curious to hear Knight's opinion on the builder approach. While true it does not supply an OOTB solution for chaining additional generators (nor custom generators), the fact that it...
Knight isn't a maintainer, so his approval doesn't carry any weight from a workflow perspective (nor would you be able to merge even with maintainer approval, a maintainer has to...
Would it be better to create either 1. An extension interface for `RecipeInput`, with defaulted methods for the necessary context, and then patch in local wrappers for those calls instead...
Would it make more sense to always check `disableSweepAttack` instead of requiring that the attack is a critical _and_ `disableSweepAttack` is set to true? They seem like independent events to...