Brennan Ravenscroft

Results 242 comments of Brennan Ravenscroft

I think the only thing we can do here is have `idePostSync` generate the folders

> What is the reasoning for this? Consistency in formatting for the files included with the MDK (the current files have arbitrary formatting) as well as an implied default for...

That would be equivalent to just including the added eclipse formatter xml (both IDEs can import it) and being done with it. Unfortunately in testing it seemed that `enforceCheck false`...

From local testing `enforceCheck false` doesn't appear to actually function, so we can reduce this to adding the necessary template lines commented out.

Default maven path before this change: `com\example\examplemod\MDK-main\1.0.0\MDK-main-1.0.0.jar` Default maven path after this change: `com\example\examplemod\examplemod\1.0.0\examplemod-1.0.0.jar`

I wasn't sure if there would be other implications of fiddling with the project name (does it change the name displayed in an IDE?) Also, the project name is seldom...

@Fuzss With the addition of multiple (and dist-specific) mod entrypoints in https://github.com/neoforged/FancyModLoader/pull/126, does this issue report still have merit? The prior usecase appears to be covered by the new features.

Apoth recently started shipping [the following mixin](https://github.com/Shadows-of-Fire/Apotheosis/blob/1.19/src/main/java/shadows/apotheosis/mixin/IForgeEntityMixin.java#L28) which disables the legacy `maxUpStep` field and forces use of the forge-provided `STEP_HEIGHT_ADDITION` attribute instead for consistency. Modification of `maxUpStep` in forge has...

I think it's unreasonable to expect implementers to have to deal with a `@Nullable` level (since it pushes the burden of a null check on everyone else) - but `BlockGetter`...

I do not believe this event provides any functionality that cannot be accomplished via the `EntityTickEvent`.