Scott Mitchell
Scott Mitchell
@DataTables - Just curious...can you clarify the need for 2 separate repositories (1 for source and 1 for build)?
@DataTables - Ok sounds good. I have much more commonly see the .gitignore (and release packages with generated files if needed) used as opposed to introducing another repo to solve...
> some transports may not give by-key access to the headers (because of streaming, what not) In case of streaming is the thought that the iterator will block until more...
> Given that changing the text map to provide direct get/set methods would be backwards incompatible change Is this true? As suggested in https://github.com/opentracing/opentracing-java/issues/169#issuecomment-324694434 it could be done with a...
@bhs - thanks for clarifying. 1.6 compatibility makes sense.
@yurishkuro - please reach out to me offline to discuss in more detail
https://github.com/apple/servicetalk/runs/8104135574?check_suite_focus=true ``` ResponseCancelTest.connectionCancelWaitingForPayloadBody(boolean) [1] finishRequest=false java.util.concurrent.TimeoutException: connectionCancelWaitingForPayloadBody(boolean) timed out after 30 seconds at org.junit.jupiter.engine.extension.TimeoutExceptionFactory.create(TimeoutExceptionFactory.java:29) at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:58) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestTemplateMethod(TimeoutExtension.java:94) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103) at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106) at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)...
timeout during local build, maybe we need to increase timeouts too? ``` HttpLifecycleObserverTest#testClientCancelsRequestAfterResponse(HttpProtocol) [1] protocol=HTTP_1 java.util.concurrent.TimeoutException: testClientCancelsRequestAfterResponse(io.servicetalk.http.netty.HttpProtocol) timed out after 10 seconds at org.junit.jupiter.engine.extension.TimeoutExceptionFactory.create(TimeoutExceptionFactory.java:29) at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:58) at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156) at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)...
https://github.com/apple/servicetalk/actions/runs/3278802234/jobs/5397613817 ``` PublisherProtobufResourcesTest > postMapFail(RouterApi) > io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.postMapFail(RouterApi)[4] FAILED org.opentest4j.AssertionFailedError: Unexpected exception type thrown, expected: but was: at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:67) at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:35) at org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3082) at io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.testPostMapFail(PublisherProtobufResourcesTest.java:112) at io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.lambda$postMapFail$2(PublisherProtobufResourcesTest.java:100) at io.servicetalk.http.router.jersey.AbstractJerseyStreamingHttpServiceTest.runTwiceToEnsureEndpointCache(AbstractJerseyStreamingHttpServiceTest.java:392)...
https://github.com/apple/servicetalk/pull/2412/checks?check_run_id=9238224898 ``` PublisherProtobufResourcesTest.[4] BLOCKING_STREAMING Expected: an instance of java.io.IOException but: is a java.lang.InterruptedException at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.testPostMapSingleFail(PublisherProtobufResourcesTest.java:173) at io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.lambda$postMapSingleResponseFail$8(PublisherProtobufResourcesTest.java:162) at io.servicetalk.http.router.jersey.AbstractJerseyStreamingHttpServiceTest.runTwiceToEnsureEndpointCache(AbstractJerseyStreamingHttpServiceTest.java:392) at io.servicetalk.data.protobuf.jersey.PublisherProtobufResourcesTest.postMapSingleResponseFail(PublisherProtobufResourcesTest.java:162) ```