Scott Mitchell
Scott Mitchell
https://github.com/apple/servicetalk/pull/2684/checks?check_run_id=16351475169 ``` ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=DEFAULT_HTTP_EXECUTION_STRATEGY filter=null LB=OFFLOAD_NEVER_STRATEGY CF=OFFLOAD_NONE_STRATEGY java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58) at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562) at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328) Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at Send,...
https://github.com/apple/servicetalk/pull/2690/checks?check_run_id=16697253580 ``` ClientEffectiveStrategyTest.Type=MULTI_DEFAULT_STRATEGY_SINGLE_BUILDER builder=OFFLOAD_NONE_STRATEGY filter=null LB=DEFAULT_HTTP_EXECUTION_STRATEGY CF=null java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58) at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562) at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328) Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-3 at Send,...
https://github.com/apple/servicetalk/pull/2769/checks?check_run_id=19163365328 ``` ClientEffectiveStrategyTest.Type=SINGLE_BUILDER builder=null filter=null LB=OFFLOAD_NONE_STRATEGY CF=OFFLOAD_NONE_STRATEGY java.lang.AssertionError: API=BLOCKING_AGGREGATED, apiStrategy=OFFLOAD_EVENT_STRATEGY, clientStrategy=DEFAULT_HTTP_EXECUTION_STRATEGY, expectedStrategy=OFFLOAD_NONE_STRATEGY. Async Errors! See suppressed at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:58) at io.servicetalk.http.netty.ClientEffectiveStrategyTest$ClientInvokingThreadRecorder.verifyOffloads(ClientEffectiveStrategyTest.java:562) at io.servicetalk.http.netty.ClientEffectiveStrategyTest.clientStrategy(ClientEffectiveStrategyTest.java:328) ... Suppressed: java.lang.AssertionError: Expected IoThread or ForkJoinPool-1-worker-1 at...
I will close this as it is no longer a priority.
@idelpivnitskiy - should we close this or do you still think we need this?
m1 MacBook local build: ``` java -version openjdk version "1.8.0_342" OpenJDK Runtime Environment (Zulu 8.64.0.15-CA-macos-aarch64) (build 1.8.0_342-b07) OpenJDK 64-Bit Server VM (Zulu 8.64.0.15-CA-macos-aarch64) (build 25.342-b07, mixed mode) ``` ``` OffloadingTest...
https://github.com/apple/servicetalk/actions/runs/4358111113/jobs/7618265865 ``` SingleRequestOrResponseApiTest > serverResponseStreamingRouteFailsOnSecondRequestItem(boolean, boolean) > io.servicetalk.grpc.netty.SingleRequestOrResponseApiTest.serverResponseStreamingRouteFailsOnSecondRequestItem(boolean, boolean)[1] FAILED java.lang.AssertionError: Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at io.servicetalk.grpc.netty.SingleRequestOrResponseApiTest.serverResponseStreamingRouteFailsWithInvalidArgument(SingleRequestOrResponseApiTest.java:140) at io.servicetalk.grpc.netty.SingleRequestOrResponseApiTest.serverResponseStreamingRouteFailsOnSecondRequestItem(SingleRequestOrResponseApiTest.java:130) ```
https://github.com/apple/servicetalk/runs/17377699234 ``` SingleRequestOrResponseApiTest.streamingService=false, streamingClient=false java.lang.AssertionError: Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at io.servicetalk.grpc.netty.SingleRequestOrResponseApiTest.serverResponseStreamingRouteFailsWithInvalidArgument(SingleRequestOrResponseApiTest.java:140) at io.servicetalk.grpc.netty.SingleRequestOrResponseApiTest.serverResponseStreamingRouteFailsOnSecondRequestItem(SingleRequestOrResponseApiTest.java:130) ```
LinkedTransferQueue also does `Thread.yield` and provides similar results for yield_count == 1 ... lets start with this queue first: https://github.com/apple/servicetalk/pull/2386
https://github.com/apple/servicetalk/pull/2684/checks?check_run_id=17275743063 ``` IoUringTest.ioUringIsAvailableOnLinux(boolean) [1] noOffloading=false java.util.concurrent.TimeoutException: ioUringIsAvailableOnLinux(boolean) timed out after 30 seconds Suppressed: java.lang.InterruptedException at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1040) at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1345) at java.base/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:232) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:94) at io.servicetalk.http.netty.IoUringTest.ioUringIsAvailableOnLinux(IoUringTest.java:95) ```