Scott Mitchell

Results 136 comments of Scott Mitchell
trafficstars

https://github.com/apple/servicetalk/runs/5382461211 ``` MalformedDataAfterHttpMessageTest.[1] true io.servicetalk.transport.netty.internal.StacklessClosedChannelException at io.servicetalk.transport.netty.internal.NettyChannelPublisher.channelOnError(Unknown Source) Caused by: io.servicetalk.http.netty.HttpObjectDecoder$StacklessDecoderException: Invalid preface character before the start-line of the HTTP message Caused by: io.servicetalk.utils.internal.IllegalCharacterException: '?' (0x00), expected [CR (0x0d), LF...

https://github.com/apple/servicetalk/runs/6620007764 ``` MalformedDataAfterHttpMessageTest.[1] true io.servicetalk.transport.netty.internal.StacklessClosedChannelException at io.servicetalk.transport.netty.internal.NettyChannelPublisher.channelOnError(Unknown Source) Caused by: io.servicetalk.http.netty.HttpObjectDecoder$StacklessDecoderException: Invalid preface character before the start-line of the HTTP message Caused by: io.servicetalk.utils.internal.IllegalCharacterException: '?' (0x00), expected [CR (0x0d), LF...

https://github.com/apple/servicetalk/pull/2372/checks?check_run_id=8528212615 ``` MalformedDataAfterHttpMessageTest.[1] true io.servicetalk.transport.netty.internal.StacklessClosedChannelException at io.servicetalk.transport.netty.internal.NettyChannelPublisher.channelOnError(Unknown Source) Caused by: io.servicetalk.http.netty.HttpObjectDecoder$StacklessDecoderException: Invalid preface character before the start-line of the HTTP message Caused by: io.servicetalk.utils.internal.IllegalCharacterException: '?' (0x00), expected [CR (0x0d), LF...

https://ci.servicetalk.io/job/servicetalk-master-prb/915/testReport/junit/io.servicetalk.http.netty/InsufficientlySizedExecutorHttpTest/insufficientServerCapacityStreaming_1___capacity__0_thread_based__false_/ ``` org.junit.runners.model.TestTimedOutException: test timed out after 90000 milliseconds at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:502) at io.servicetalk.concurrent.api.ExecutorCompletionStage$GetListener.blockingWait(ExecutorCompletionStage.java:820) at io.servicetalk.concurrent.api.ExecutorCompletionStage.waitingGet(ExecutorCompletionStage.java:652) at io.servicetalk.concurrent.api.ExecutorCompletionStage.get(ExecutorCompletionStage.java:509) at io.servicetalk.http.netty.InsufficientlySizedExecutorHttpTest.insufficientServerCapacityStreaming(InsufficientlySizedExecutorHttpTest.java:128) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at...

I wouldn't say #346 fixes the issue but is a work around so the test no longer fails. I think https://github.com/servicetalk/servicetalk/pull/353 should be the proper fix, and we can backout...

I see the same exception occurring more frequently on windows too https://github.com/apple/servicetalk/pull/977#discussion_r396612874

https://github.com/apple/servicetalk/runs/8172098957 ``` GrpcLifecycleObserverTest.testResponseStream(boolean) [1] error=false org.mockito.exceptions.verification.NoInteractionsWanted: No interactions wanted here: -> at io.servicetalk.grpc.netty.GrpcLifecycleObserverTest.verifyObservers(GrpcLifecycleObserverTest.java:271) But found this interaction on mock 'serverResponseObserver': -> at io.servicetalk.grpc.utils.BiGrpcLifecycleObserver$BiGrpcResponseObserver.onResponseDataRequested(BiGrpcLifecycleObserver.java:199) *** For your reference, here is the...

https://github.com/apple/servicetalk/runs/8280598657 ``` GrpcLifecycleObserverTest.testResponseStream(boolean) [1] error=false org.mockito.exceptions.verification.NoInteractionsWanted: No interactions wanted here: -> at io.servicetalk.grpc.netty.GrpcLifecycleObserverTest.verifyObservers(GrpcLifecycleObserverTest.java:271) But found this interaction on mock 'serverResponseObserver': -> at io.servicetalk.grpc.utils.BiGrpcLifecycleObserver$BiGrpcResponseObserver.onResponseDataRequested(BiGrpcLifecycleObserver.java:199) *** For your reference, here is the...

From @bondolo https://github.com/apple/servicetalk/pull/2203#discussion_r866337061 > If it is not possible to recognize the source as potentially blocking on hasNext() then perhaps demand should be reduced to 1. > There doesn't seem...

From @bondolo https://github.com/apple/servicetalk/pull/2203/commits/0cf2ac248e46f89c7bf8f081d5a266d903837cdf#r866337445 > A more detailed comment on itemsToRequestNext describing problem with blocking Iterator might be helpful.