Scott Mitchell

Results 136 comments of Scott Mitchell

https://github.com/apple/servicetalk/pull/2120/checks?check_run_id=5369476655 ``` FullDuplexAndSequentialModeTest.defaultFullDuplex() java.util.concurrent.TimeoutException: defaultFullDuplex() timed out after 30 seconds Suppressed: java.lang.InterruptedException at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1048) at java.base/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:230) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:91) at io.servicetalk.http.netty.FullDuplexAndSequentialModeTest.defaultFullDuplex(FullDuplexAndSequentialModeTest.java:59) ```

``` FullDuplexAndSequentialModeTest.deferResponseUntilAfterRequestSent() java.util.concurrent.TimeoutException: deferResponseUntilAfterRequestSent() timed out after 30 seconds Suppressed: java.lang.InterruptedException: sleep interrupted at java.lang.Thread.sleep(Native Method) at io.servicetalk.http.netty.FullDuplexAndSequentialModeTest.deferResponseUntilAfterRequestSent(FullDuplexAndSequentialModeTest.java:80) ```

https://github.com/apple/servicetalk/pull/2384/checks?check_run_id=8692706122 ``` FullDuplexAndSequentialModeTest.defaultFullDuplex() java.util.concurrent.TimeoutException: defaultFullDuplex() timed out after 30 seconds ... Suppressed: java.lang.InterruptedException at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1048) at java.base/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:230) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:91) at io.servicetalk.http.netty.FullDuplexAndSequentialModeTest.defaultFullDuplex(FullDuplexAndSequentialModeTest.java:59) ```

https://github.com/apple/servicetalk/pull/2412/checks?check_run_id=9259610509 ``` FullDuplexAndSequentialModeTest.defaultFullDuplex() java.util.concurrent.TimeoutException: defaultFullDuplex() timed out after 30 seconds Suppressed: java.lang.InterruptedException at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1343) at java.base/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:232) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:91) at io.servicetalk.http.netty.FullDuplexAndSequentialModeTest.defaultFullDuplex(FullDuplexAndSequentialModeTest.java:59) ```

I think this applies more generally than just `CommanderUtils`. Let me update the title

https://github.com/apple/servicetalk/runs/5207931543?check_suite_focus=true on snapshot build: ``` ConnectionCloseHeaderHandlingTest$PipelinedRequestsTest.3: useUds=false, viaProxy=true, awaitRequestPayload=false java.util.concurrent.ExecutionException: io.servicetalk.transport.netty.internal.CloseHandler$CloseEventObservedException: PROTOCOL_CLOSING_INBOUND(The application protocol closed the read side of this connection. This maybe the result of sending an HTTP header...

``` ConnectionCloseHeaderHandlingTest$PipelinedRequestsTest.4: useUds=false, viaProxy=true, awaitRequestPayload=true java.util.concurrent.ExecutionException: io.servicetalk.transport.netty.internal.CloseHandler$CloseEventObservedException: PROTOCOL_CLOSING_OUTBOUND(The application protocol closed the write side of this connection. This maybe the result of sending an HTTP header such as Connection: close.)...

https://github.com/apple/servicetalk/runs/5546627377 ``` ConnectionCloseHeaderHandlingTest$NonPipelinedRequestsTest.27: useUds=false, viaProxy=true, awaitRequestPayload=false, requestInitiatesClosure=true, noRequestContent=false, noResponseContent=true java.lang.AssertionError: Expected: "0" but: was "15" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at io.servicetalk.http.netty.ConnectionCloseHeaderHandlingTest$NonPipelinedRequestsTest.testConnectionClosure(ConnectionCloseHeaderHandlingTest.java:322) ```

snapshot build https://github.com/apple/servicetalk/runs/6330132708 ``` ConnectionCloseHeaderHandlingTest$PipelinedRequestsTest.4: useUds=false, viaProxy=true, awaitRequestPayload=true java.util.concurrent.ExecutionException: io.servicetalk.transport.netty.internal.CloseHandler$CloseEventObservedException: PROTOCOL_CLOSING_INBOUND(The application protocol closed the read side of this connection. This maybe the result of sending an HTTP header such...

Note that `PartitionedHttpClientBuilder` has a `PartitionHttpClientBuilderConfigurator` for a similar purpose. We should try to align the approach we take with the `DefaultMultiAddressHttpClientBuilder`