Scott Mitchell

Related items for consideration: - https://github.com/apple/servicetalk/pull/980#discussion_r396835362 - https://github.com/apple/servicetalk/pull/980#discussion_r396835687

https://github.com/apple/servicetalk/runs/3127524814 ``` DnsServiceDiscovererObserverTest.aQueryResolutionResultOneBecameUnavailable() java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:264) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.lambda$aQueryResolutionResultOneBecameUnavailable$10(DnsServiceDiscovererObserverTest.java:211) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResult(DnsServiceDiscovererObserverTest.java:254) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResultOneBecameUnavailable(DnsServiceDiscovererObserverTest.java:210) ```

https://github.com/apple/servicetalk/runs/3467796734 ``` DnsServiceDiscovererObserverTest.aQueryResolutionResultNewAvailableOneUnavailable() java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:264) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.lambda$aQueryResolutionResultNewAvailableOneUnavailable$11(DnsServiceDiscovererObserverTest.java:227) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResult(DnsServiceDiscovererObserverTest.java:254) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResultNewAvailableOneUnavailable(DnsServiceDiscovererObserverTest.java:222) ```

https://github.com/apple/servicetalk/runs/4549344854 ``` java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:264) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.lambda$aQueryResolutionResultOneBecameUnavailable$10(DnsServiceDiscovererObserverTest.java:214) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResult(DnsServiceDiscovererObserverTest.java:254) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.aQueryResolutionResultOneBecameUnavailable(DnsServiceDiscovererObserverTest.java:210) ```

I reproduced locally after ~6k runs.

https://github.com/apple/servicetalk/runs/2027917412 ``` java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:270) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.srvQueryResolutionResult(DnsServiceDiscovererObserverTest.java:292) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at...

https://github.com/apple/servicetalk/runs/3090911687 ``` java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:264) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.srvQueryResolutionResult(DnsServiceDiscovererObserverTest.java:286) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:688) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at...

https://github.com/apple/servicetalk/pull/1673/checks?check_run_id=3270186565 ``` java.lang.AssertionError: Unexpected TTL value Expected: is but: was at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.assertResolutionResult(DnsServiceDiscovererObserverTest.java:264) at io.servicetalk.dns.discovery.netty.DnsServiceDiscovererObserverTest.srvQueryResolutionResult(DnsServiceDiscovererObserverTest.java:286) ```

Our transport utilities are currently located in `io.servicetalk.transport.netty.*`. Here is a good place to start: - client side [TcpConnector](https://github.com/apple/servicetalk/blob/main/servicetalk-tcp-netty-internal/src/main/java/io/servicetalk/tcp/netty/internal/TcpConnector.java) - server side [TcpServerBinder](https://github.com/apple/servicetalk/blob/main/servicetalk-tcp-netty-internal/src/main/java/io/servicetalk/tcp/netty/internal/TcpServerBinder.java) - Netty to ServiceTalk reactive streams adapters:...

from https://github.com/apple/servicetalk/issues/1569 https://github.com/apple/servicetalk/runs/2633917236?check_suite_focus=true ``` java.util.concurrent.TimeoutException: executorIsPreserved() timed out after 30 seconds at org.junit.jupiter.engine.extension.TimeoutInvocation.createTimeoutException(TimeoutInvocation.java:70) ... Suppressed: java.lang.InterruptedException at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:998) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304) at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231) at io.servicetalk.concurrent.api.SourceToFuture.get(SourceToFuture.java:91) at io.servicetalk.concurrent.api.PublisherBufferConcurrencyTest.runTest(PublisherBufferConcurrencyTest.java:168) at io.servicetalk.concurrent.api.PublisherBufferConcurrencyTest.executorIsPreserved(PublisherBufferConcurrencyTest.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native...