Scott Todd
Scott Todd
Thanks for the reviews! Should I merge this myself, or would one of the project maintainers like to do that?
Same comment for https://github.com/ROCm/hipSOLVER/pull/386, which it looks like is awaiting one more review > At least 2 approving reviews are required by reviewers with write access.
Not sure why this would be failing, but I would put `stablehlo.sort` in the category of things that are only lightly tested and used in models most of the core...
https://mlir.llvm.org/docs/Dialects/ArithOps/#arithmaximumf-arithmaximumfop `arith.maximumf`: > Returns the maximum of the two arguments, treating -0.0 as less than +0.0. If one of the arguments is NaN, then the result is also NaN. `arith.maxnumf`:...
Want to convert this to a draft? This sort of debug logging shouldn't have any value once the workflow is functional, right?
Test failed on macos bot: https://github.com/iree-org/iree/actions/runs/11627272067/job/32380320905#step:9:1650 `AttributeError: module 'enum' has no attribute 'StrEnum'` Python 3.10
Test also failed on Windows bot, same error: https://github.com/iree-org/iree/actions/runs/11627295212/job/32380385457#step:8:1703 The release build succeeded though, so that's less urgent to fix
> We need to guide people better than this. Yes please! https://github.com/iree-org/iree/issues/15487
The suggested proposal SGTM. I might even want to default to having LLVM use the current host for the target CPU and available features (if those are different), then have...
We can certainly update the docs (https://iree.dev/guides/deployment-configurations/cpu/#compile-a-program) and start with a warning from the compiler if information is omitted and generic is used as the default. I'm seeing a proliferation...