Scott Todd

I found a few issues here, but haven't yet figured out the right solutions. --- ### `IREE_ASSERT_OK` leaks `iree_status_t` structures for non-ok statuses ``` 71: ==108401==ERROR: LeakSanitizer: detected memory leaks...

Yeah, the status leaks came up when I broke dlopen by passing the wrong flags - I finally saw accurate asan stacks, but for status code and not Vulkan code...

Editing the Vulkan Loader code linked above helped me get useful reports from ASAN, which all pointed to leaks throughout `libnvidia-glcore.so` on my machine. When I switch to using SwiftShader,...

Updating SwiftShader helped! Most Vulkan tests are fixed + enabled under ASan now. These remain: https://github.com/google/iree/blob/bcb6199e19d5a6320397258a8028fc5ec3459d0d/build_tools/kokoro/gcp_ubuntu/cmake/linux/x86-swiftshader-asan/build.sh#L105-L111 with logs like ``` Tracer caught signal 11: addr=0x0 pc=0x50c558 sp=0x7fb28fdffd10 ==50923==LeakSanitizer has encountered...

Still seeing a few ASan+Vulkan tests fail occasionally with that LeakSanitizer crash `e2e/models/mnist_fake_weights.mlir`: https://github.com/iree-org/iree/runs/7768946982?check_suite_focus=true `e2e/models/fragment_000.mlir.test`: https://github.com/iree-org/iree/pull/10004 Seems like the failures are flakes, since they keep popping up one at a...

> So something I haven't seen explicitly spelled out anywhere is what is the "if these aren't supported, the device isn't supported and falls back to CPU" Falling back from...

I think the change in https://github.com/iree-org/iree/commit/51893996b28d672e6ea56e6c4da7c86d8785059a was enough to enable this. I also audited our usage of `CMAKE_CROSSCOMPILING` and what we have today looks good (no unnecessary restrictions). ```diff function(iree_get_executable_path...

Is this only happening with `iree-mlir-lsp-server`, or with other binaries also? That particular binary is for developer use via IDEs and is not depended on by any tests or anything...

This (and a similar tagging for a text statistics summary outside of Tracy) could also be useful in comparing IREE's equivalent of `-O0` and `-O2`/`-O3`. Compiling with no optimizations (mainly...

I ran a test with hardcoded tags to see how flexible the UI is and how much we would need to summarize:    if I was debugging a...