Scott Todd

Results 405 comments of Scott Todd

Ping? Does anyone monitor this repository? Who should review this?

Thanks! We've been carrying this patch in TheRock for some time now: https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/llvm-project/0005-Rework-constructHipPath-so-HIP_PATH-env-var-is-lower.patch and we're making a push to get to 0 patches across LLVM, rocm-libraries, rocm-systems, etc.

cc @stellaraccident > Also is the issue you're trying to solve the case where you build hipcc locally and you don't want that built hipcc to use the ROCm installed...

Maybe we could bake some `--hip-path` or `--rocm-path` settings into the packages? I'm not sure... these environment variables are some pretty big tech debt that we've been trying to fix.

I think by default all ROCm tools should know where other ROCm tools in the same install are located and should call them directly. Relying on the system path and...