Scott Todd

Results 405 comments of Scott Todd

Ben pointed out that a source location listing will let Tracy resolve to the same thing, even within MLIR, so a summary tag would still be preferred over an entire...

I started working on this, looking at source location listings. To start, I manually dumped .mlir file from `--mlir-print-ir-after=iree-flow-deduplicate-executables` then hardcoded this block to use the path to that file:...

> summary tag will be very useful when skimming/looking at the summary view and trying to see what's taking time Where would you be looking for that? I only see...

Gotcha. So all together, we could 1. use heuristics to name the dispatches 2. add dynamic parameters to user text via tags 3. add source location listings at one of...

A few more cases of this popped up since I last looked: https://github.com/google/iree/blob/2322a1694d8800a86c319a3b158901f8ec3e5147/llvm-external-projects/iree-dialects/CMakeLists.txt#L42-L45 https://github.com/tensorflow/mlir-hlo/blob/1b2588b24e309d0503bcb02c58fab5445f8c3046/CMakeLists.txt#L69 I'm not quite sure what the right setup is, but https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/TableGen.cmake is generally structured to support...

> Perhaps a duplicate of #4662? Eh, related but I'd say no. That issue is more broad, while this issue has a specific scenario that is broken.

@okkwon do you want to review this also? (you filed a similar feature request in https://github.com/iree-org/iree/issues/9132)

The [`build_tools/buildkite/samples.yml`](https://github.com/iree-org/iree/blob/main/build_tools/buildkite/samples.yml) pipeline installs the Python packages from https://github.com/iree-org/iree/releases. It probably makes sense to keep that separate from the per-commit pre-submit and post-submit CI workflow, but we still have a...

The proposed solution sounds reasonable to me. I imagine there would be a few common recipes modeled after the use cases you listed at the top (docs -> skip CI...

> Use a string in the PR description to skip CI instead of a label This SGTM. I don't think splitting the CI into two classes of presubmits should be...