rocSOLVER icon indicating copy to clipboard operation
rocSOLVER copied to clipboard
verified publisher icon ROCm

Fix CMAKE_INSTALL_PREFIX init behavior on Win32.

Open ScottTodd opened this issue 8 months ago • 2 comments

Per the guidance at https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html, CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT can be "used by project code to change the default without overriding a user-provided value".

This allows users and integration projects like https://github.com/ROCm/TheRock to set an install path of their choosing while still defaulting to this project's preferred value if the value is not already set. For more context, see https://github.com/ROCm/TheRock/pull/340.

ScottTodd avatar Apr 02 '25 22:04 ScottTodd

Thanks for the reviews! Should I merge this myself, or would one of the project maintainers like to do that?

ScottTodd avatar May 14 '25 21:05 ScottTodd

Same comment for https://github.com/ROCm/hipSOLVER/pull/386, which it looks like is awaiting one more review

At least 2 approving reviews are required by reviewers with write access.

ScottTodd avatar May 14 '25 21:05 ScottTodd